Closed
Conversation
long-nt-tran
force-pushed
the
long/go-sdk-pkg-upgrade
branch
3 times, most recently
from
f2f789e to
7f37a24
Compare
long-nt-tran
force-pushed
the
long/go-sdk-pkg-upgrade
branch
from
7f37a24 to
5dcfcb9
Compare
long-nt-tran
changed the title
Contributor
|
For OSS repos use forks. We don't want a ton of branches in main repo. |
chaptersix
reviewed
Mar 30, 2026
| github.com/maruel/panicparse/v2 v2.4.0 | ||
| github.com/mitchellh/mapstructure v1.5.0 | ||
| github.com/nexus-rpc/sdk-go v0.5.2-0.20260211051645-26b0b4c584e5 | ||
| github.com/nexus-rpc/sdk-go v0.6.0 |
Contributor
There was a problem hiding this comment.
github.com/nexus-rpc/sdk-go v0.5.2-0.20260211051645-26b0b4c584e5 this was likely pointing at main. Are you sure the newest release is new that this?
Contributor
Author
There was a problem hiding this comment.
I think this is slightly outdated, will run go mod tidy again
Contributor
Author
thanks, let me do that. The PR guide I saw mentioned to open the PR on "name/feature" branch against main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
v1.41.1from Mar 17 2026go mod tidycd common/testing/mocksdk && go generate-- generated changes incommon/testing/mocksdk/client_mock.gotests/nexus_workflow_test.goWhy?
To use the latest version
How did you test it?